Hi Alan!
I'm not sure why it would be an improvement to make it a method.
As Roger said, with a final variable, the compiler is able to eliminate
dead code altogether.
I think, if later there's a need to make the decision
dynamic/overridable, it can be easily changed, as it's not part of
public API.
Sincerely yours,
Ivan
On 05.01.2015 21:47, Alan Bateman wrote:
On 05/01/2015 17:41, Ivan Gerasimov wrote:
:
Here's another update:
http://cr.openjdk.java.net/~igerasim/8067951/4/webrev/
The optimized loop is used both on Unix and on Windows, if there were
no quotes found in PATH.
Not a big deal, of course, but it should save a few nano-seconds
during startup.
This approach looks okay to me. A small improvement would be to change
it to a method that returns a boolean.
-Alan
