This looks fine to me too ( removal of streams usage and JRT, for 7uXX ).. -Chris.
On 9 Jan 2015, at 11:07, Seán Coffey <sean.cof...@oracle.com> wrote: > Thanks for reviewing Daniel. I'm mark you as author. If I can get a jdk7u > Reviewer to review, I'll push this. > Will update copyright before pushing also. > > regards, > Sean. > > On 08/01/15 14:55, Daniel Fuchs wrote: >> Hi Seán, >> >> Thanks for taking care of that :-) >> >> It looks good to me. You might want to set the copyright year to 2015. >> Best regards, >> >> -- daniel >> >> On 08/01/15 15:41, Seán Coffey wrote: >>> I've taken suggested test code from Daniel and am looking to backport >>> 8066612 to jdk7u-dev. The test differs slightly in that it used the >>> non-lambda approach (ClassNameListBuilder) >>> >>> I've reduced the number of run counts also (one ovm run for secure and >>> one for non-secure mode) - As a result and given the large number of >>> classes loaded, I've bumped PermSize up to 128m - no harm to stress that >>> side of things also I guess. >>> >>> Test passes on all JPRT platforms. I'll revert to smaller class load >>> counts if issues are seen with this test approach. >>> >>> webrev : http://cr.openjdk.java.net/~coffeys/webrev.8066612.jdk7u/webrev/ >>> bug ID : https://bugs.openjdk.java.net/browse/JDK-8066612 >>> >>> regards, >>> Sean. >>> >>> >> >
