Joe,
Thank you for the review. Will fix the format issue on line 299 before
the push. About @run: If I recall it correctly, it is not needed when
the test resides in a folder (or a tree) that contains the
TEST.properties file with defined TestNG.dirs option inside it.
With Best Regards,
Aleksej
On 01/23/2015 09:29 PM, huizhe wang wrote:
Hi Aleksej,
Looks good. There is a minor format issue at line 299.
Note that, for JDK 9, we now have functional/unit tests under
jaxp/test. This test would fix in
javax/xml/jaxp/unittest/javax/xml/transform. For test format, please
take a look at a functional test (javax/xml/jaxp/functional) since
Tristan has refactored them, and SQE plans to do the same with the
unit tests. For a testng test, the @run tag is not necessary.
The jaxp tests are defined in its own testset "jaxp".
Thanks,
Joe
On 1/19/2015 3:25 AM, Aleksej Efimov wrote:
Hi,
Please, review the fix for the XSL substring function failures. Two
issues were reported during usage of this function:
1. Runtime internal error with negative length:
https://bugs.openjdk.java.net/browse/JDK-8062923
2. Wrong answer when -Inf length is used:
https://bugs.openjdk.java.net/browse/JDK-8062924
These two issues can be solved by fix proposed for the review:
http://cr.openjdk.java.net/~aefimov/8062923/webrev.00
Testing:
xml related regression tests (with new test) - no failures (from jdk
and jaxp repos).
JCK xml related tests - no failures.
With Best Regards,
Aleksej
