On 5/02/2015 6:17 AM, Christian Thalinger wrote:

On Feb 4, 2015, at 9:44 AM, Daniel Fuchs <daniel.fu...@oracle.com> wrote:

On 04/02/15 17:21, Christian Thalinger wrote:

-const jlong MAX_DIFF_SECS = 0x0100000000;   //  2^32
+const jlong MAX_DIFF_SECS = 0x0100000000LL; //  2^32

Don’t use LL directly; we have a compiler-dependent macro for this:

Sorry my bad - I forgot we had a macro for this. :(


CONST64


Hi Christian,

I have pushed the change as it was reviewed by David, Coleen, & Staffan.

I have logged https://bugs.openjdk.java.net/browse/JDK-8072482
(assigned to myself) as a followup bug.

That’s fine, thanks.  Maybe you can fix a couple other places where LL-usage 
crept in too.

./cpu/zero/vm/bytecodeInterpreter_zero.inline.hpp: if (op1 == (jlong) 0x8000000000000000LL && op2 == -1) return op1; ./cpu/zero/vm/bytecodeInterpreter_zero.inline.hpp: if (op1 == (jlong) 0x8000000000000000LL && op2 == -1) return 0; ./share/vm/opto/divnode.cpp: const uint64_t two63 = 0x8000000000000000LL; // 2**63. ./share/vm/gc_implementation/g1/g1CollectorPolicy.cpp: gclog_or_tty->print_cr("ALL PAUSES");
./os/aix/vm/os_aix.cpp:    return 0xFFFFFFFFFFFFFFFFLL;
./os/aix/vm/os_aix.cpp: sys_time = thrdentry.ti_ru.ru_stime.tv_sec * 1000000000LL + thrdentry.ti_ru.ru_stime.tv_usec * 1000LL; ./os/aix/vm/os_aix.cpp: user_time = thrdentry.ti_ru.ru_utime.tv_sec * 1000000000LL + thrdentry.ti_ru.ru_utime.tv_usec * 1000LL;

David
-----


best regards,

-- daniel

Reply via email to