Hi Everyone, Webrev updated in-place (press shift-reload)
http://cr.openjdk.java.net/~dsamersoff/JDK-8073584/webrev.01/ Updated formatting. Hack in main.cpp replaced with true error check. -Dmitry On 2015-02-23 05:07, David Holmes wrote: > On 21/02/2015 4:27 AM, Dmitry Samersoff wrote: >> Hi Everyone, >> >> It's my $0.02 to the warning cleanup work. Please review: >> >> http://cr.openjdk.java.net/~dsamersoff/JDK-8073584/webrev.01/ >> >> Notes: >> >> I use an ugly trick: (void) (read() + 1) to get rid of ignored value >> warning because since gcc 4.6 just (void) is not enough. > > Why not just check the return value for correctness? > > David > >> >> -Dmitry >> >> -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources.