On 02/26/2015 01:05 PM, Alan Bateman wrote:
On 26/02/2015 02:47, Xueming Shen wrote:
Please help review the change for JDK-8073924.
issue: https://bugs.openjdk.java.net/browse/JDK-8073924
webrev: http://cr.openjdk.java.net/~sherman/8073924/webrev
This looks okay although you should avoid walking the entire file system with:
Path root1 = fs.getPath("/java.base/sun/nio.cs");
Path root1 = fs.getPath("/jdk.charsets/sun/nio/cs/ext");
Stream.concat(Files.walk(root1), Files.walk(root2))...
This looks nice :-) webrev has been updated accordingly.
http://cr.openjdk.java.net/~sherman/8073924/webrev
Thanks,
-sherman
An alternative is of course Files.walkFileTree and FileVisitor that returns
SKIP_SUBTREE.
One other thing to be aware if that jrt file system needs to change soon to
have /modules and /packages top level directories. Sundar is working on that so
I guess this test will need to be updated as part of that work.
-Alan
