On 27/02/15 02:04, Stuart Marks wrote: > On 2/19/15 9:33 AM, Chris Hegarty wrote: >> It came up recently that java.util.Arrays was missing subrange >> overloads for setAll and parallelSetAll. These methods can be easily >> written with IntStream.range. Rather than adding eight new methods for >> this, it makes sense to point developers to IntStream.range. It seems >> reasonable to add a small note to these methods, promoting the use of >> IntStream. If someone is hunting around for a subrange setAll, then >> they will inevitable end up seeing this note. >> >> http://cr.openjdk.java.net/~chegar/setAllNotes/webrev.00/webrev/ > > Hi Chris, > > Sorry I missed this -- it got buried in the usual avalanche of > core-libs-dev email. :-) > > Overall it seems reasonable, if a bit repetitive, but you've already > done the work to customize the example for each different case. In any > case, looks fine to me. > > Are you going to file a bug for this and push it in? If so, consider > this to be the review.
Thanks for the review Stuart. Pushed http://hg.openjdk.java.net/jdk9/dev/jdk/rev/d2a4b295498e -Chris. > s'marks >
