slightly safer (more likely to compile everywhere) might be to convert input length into a size_t immediately and to
#define MBYTE ((size_t) 1048576) On Mon, Mar 2, 2015 at 12:59 PM, Ivan Gerasimov <ivan.gerasi...@oracle.com> wrote: > Thank you Alan for review! > > >>> As you've noted, there is no need to update xxxAddr because the >> position is updated during swapping copy. That looks okay to me. >> >> Only updating size for the last chunk is okay too, but that a bit of coin >> toss as to whether to change this as the current code is easy to read. The >> stale comment should be removed of course. >> >> I agree that readability is important. > Below is the updated webrev. I couldn't resist to making it a bit > shorter, though :) > > BUGURL: https://bugs.openjdk.java.net/browse/JDK-8074067 > WEBREV: http://cr.openjdk.java.net/~igerasim/8074067/1/webrev/ > > I checked that the source can be built on all platforms, despite of the > warning in the comments. > > Sincerely yours, > Ivan > >
