On 23/03/2015 21:25, Mark Sheppard wrote:
Hi
please oblige and review the following fix
http://cr.openjdk.java.net/~msheppar/8068721/jdk9/corba/webrev/
http://cr.openjdk.java.net/~msheppar/8068721/jdk9/jdk/webrev/
which addresses the issue in
https://bugs.openjdk.java.net/browse/JDK-8068721
This relates to RMI-IIOP and the interplay between custom marshalling
of ValueTypes and
the corresponding serialization of a Java class, in this case
ConcurrentHashMap.
Looks like this needs a deep dive into the RMI-IIOP spec to properly
review this. I see Sean Coffey has been looking at it too so hopefully
he has cycles to help on this.
A few passing comments on the tests:
Should the tie and stub be generated by the test rather than checking in
the generated code?
The test launches ordb and and an RMI-IIOP server, I wonder if the test
library infrastructure could be used to do this instead (as we have so
many issues with multi-VM tests). Also it's using a fixed port which
might be a problem when running concurrently with other tests (esp. any
test using a naming service as it will be using 1050 too).
The patch adds RMI-IIOP tests to the jdk_rmi test group. I think to date
that we've put CORBA and RMI-IIOP tests in jdk_other. I realize this has
implications for where the tests are placed.
-Alan.
