On 23/03/2015 15:45, Chris Hegarty wrote:
Here is an updated version of the FieldSetter API, with all comments
to date incorporated.
http://cr.openjdk.java.net/~chegar/8071472/02/specdiff/overview-summary.html
Final spec comments welcome, after which I intend to submit a CCC
request.
In fieldSetter() then a small typo "associate with current object" =>
missing "the".
Also in fieldSetter() then the first sentence might be clearer if you
split it into two with the second sentence starting as "The FieldSetter
gives write access ...".
In FieldSetter then the first sentence might read a bit better if you
change "including final" to "including final fields".
A suggestion for the second sentence is to change is to: "A thread
executing readObject gets the FieldSetter by invoking the fieldSetter()
method. The FieldSetter can be used to set any instance field of the
object being deserialized".
In the third sentence then it might read a bit better if you drop the
comma before "where applicable".
I wonder if it might make sense to just drop the paragraph that lists
the conditions for which ISE and IAE are thrown as this is repeated in
each of the set methods.
Otherwise it looks good to me.
-Alan.
