On 30/03/15 16:18, Jason Mehrens wrote:
For the test shouldn't you include a test for getLoggerNames to check that if 
the returned Enumeration is an instanceof Iterator then its remove method must 
throw an UnsupportedOperationException?  That makes it clear as to why you are 
using Collections.enumeration.

Good idea - it wouldn't hurt.

-- daniel



Jason

----------------------------------------
Date: Mon, 30 Mar 2015 11:27:21 +0200
From: daniel.fu...@oracle.com
To: marti...@google.com; claes.redes...@oracle.com
Subject: Re: RFR: 7113878: LogManager - namedLoggers should be 
ConcurrentHashMap instead of Hashtable
CC: core-libs-dev@openjdk.java.net

Thanks all for your reviews!

If I don't hear more then
http://cr.openjdk.java.net/~dfuchs/webrev_7113878/webrev.01/

is what I'm going to push.

best regards,

-- daniel

On 28/03/15 00:39, Martin Buchholz wrote:
Claes,

Right you are - I stand corrected!

On Fri, Mar 27, 2015 at 4:02 PM, Claes Redestad <claes.redes...@oracle.com>
wrote:


On 2015-03-27 21:12, Martin Buchholz wrote:

Random advice - the default concurrency level of ConcurrentHashMap is 16,
and that is almost always more than needed, probably also including here.


I believe JSR-166e (JDK8 and onwards) mostly removed the concept of
concurrency level from ConcurrentHashMap (while it's still there in some
constructors to confuse things). I recall some tests showing that the
difference in footprint between CHM and regular HashMap/Hashtable is now
negligible even for empty, default-initialized instances.

/Claes

                                        

Reply via email to