Hi Frank On Mar 31, 2015, at 7:24 AM, Lance @ Oracle <lance.ander...@oracle.com> wrote:
> Hi frank > > Can you forward the other review request as I think I thought they were the > same and deleted it Ignore this comment, the subjects were too similar but this is what needed reviewed. > > I will look at this again today The tests overall look fine. I still have the same comment WRT providing a simple comment describing each test. The key point to remember is we want to make it easier for someone to look at the test, understand what you are trying to validate, and understand the coverage of the tests. This will help future maintainers of the code. Comments are just as important in test code as it is in implementation IMHO. Best Lance > > Best > Lance > > > Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 > Oracle Java Engineering > 1 Network Drive > Burlington, MA 01803 > lance.ander...@oracle.com > Sent from my iPad > > On Mar 31, 2015, at 4:15 AM, Frank Yuan <frank.y...@oracle.com> wrote: > >> Hi Joe >> >> >> >> Do you have any comment for dom suite co-location? >> >> >> >> Best Regards >> >> Frank >> >> >> >> From: Frank Yuan [mailto:frank.y...@oracle.com] >> Sent: Wednesday, March 25, 2015 5:46 PM >> To: 'huizhe wang'; 'Core-Libs-Dev' >> Cc: 'jibing chen'; 'Gustavo Galimberti'; sandeep.konch...@oracle.com; >> 'Alexandre (Shura) Iline' >> Subject: RE: Review request for JDK-8051559: JAXP function dom tests >> conversion >> >> >> >> Hi, Joe and All >> >> >> >> We are working on moving internal jaxp functional tests to open jdk repo. >> >> This is the dom suite. Would you please review these test? Any comment will >> be appreciated. >> >> >> >> bug: https://bugs.openjdk.java.net/browse/JDK-8051559 >> >> webrev: http://cr.openjdk.java.net/~fyuan/8051559/webrev.00/ >> >> >> >> Thanks, >> >> >> >> Frank >> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
