Hi Otávio,
Thank you for your remarks. Answers are in-lined below. In general -
standalone JAXWS/B still compatible with JDK6.
Thank you,
Aleksej
On 04/13/2015 01:52 PM, Otávio Gonçalves de Santana wrote:
One Question:
Look to these classes:
MIMEPart
MIMEMessage
why do not implement AutoClosable instead Closable?
The standalone JAXWS/B still supports the JDK6 and because of that we
can't use AutoClosable (since 1.7).
Other suggestions:
On class MIMEMessage, you can use diamond resource.
private final List<MIMEPart> partsList = new ArrayList<>();
private final Map<String, MIMEPart> partsMap = new HashMap<>();
Same as previous - no diamonds in JDK6.
on ContextFinder class
try(final InputStream resourceStream =
(classLoader == null) ?
ClassLoader.getSystemResourceAsStream(resource) :
classLoader.getResourceAsStream(resource)) {
}catch (IOException e) {
throw new JAXBException(e);
}
Same as previous - no try-with-resources in JDK6
on ServiceLoaderUtil class:
static String propertyFileLookup(final String configFullPath, final
String factoryId) throws IOException {
Path path = Paths.get(configFullPath);
if (Files.exists(path)) {
Properties props = new Properties();
try(InputStream stream = Files.newInputStream(path)) {
props.load(stream);
return props.getProperty(factoryId);
}
}
returnnull;
}
no try-with-resources in JDK6
On Fri, Apr 10, 2015 at 7:09 AM, Aleksej Efimov
<aleksej.efi...@oracle.com <mailto:aleksej.efi...@oracle.com>> wrote:
Hi Joe,
Yes, the extensive testing took place before syncing the
standalone implementation to JDK: JCK, sets of jaxws/b unit tests,
JPRT testing.
Thank you for your comments and suggestions - we'll try to address
them and integrate during the next integration. About diamond
operator in MIMEMessage - not sure that we can put it there -
AFAIK the standalone JAXWS/B still supports JDK6 and we can't use
"diamonds" there.
With Best Regards,
Aleksej
On 04/10/2015 09:50 AM, huizhe wang wrote:
Hi Aleksej,
I assume the JAX-WS/JAXB standalone releases are well tested
for this integration, esp. the service finder code.
I see a great number of "<>" to "<>" changes that was
suggested by Alan in the last integration. Besides that, you
may consider removing </p>, using {@literal @} to replace
@, and the diamond operator in new expression in
MIMEMessage. Also, new
StringBuilder().append("META-INF/services/").append(jaxbContextFQCN).toString()
isn't any better than "META-INF/services/"+jaxbContextFQCN
since they'll be compiled into the same.
None of the above should prevent you from pushing your changes.
Cheers,
Joe
On 4/8/2015 1:57 PM, Aleksej Efimov wrote:
Hi,
Can I kindly ask for a review of this JAX-WS update?
With Best Regards,
Aleksej
On 04/03/2015 06:20 PM, Aleksej Efimov wrote:
Hello,
Can I have a review for a JDK9 bulk update of JAX-B/WS
from upstream projects.
Webrev:
More details in issue description:
https://bugs.openjdk.java.net/browse/JDK-8076549
Thank you,
Aleksej
--
Otávio Gonçalves de Santana
blog: http://otaviosantana.blogspot.com.br/
twitter: http://twitter.com/otaviojava
site: _http://about.me/otaviojava_
