Looks fine to me Roger. -Chris.
On 28 Apr 2015, at 14:32, Roger Riggs <roger.ri...@oracle.com> wrote: > Hi Joe, Chris, > > Thanks for the review and suggestions. > > I created a new issue for the diagnostic additions, > so the original bugid [1] can be used to accumulate additional information. > > Issue: > 8078826 <https://bugs.openjdk.java.net/browse/JDK-8078826>: Add diagnostic > info for java/lang/Runtime/exec/LotsOfOutput.java fails intermittently > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-lots-8078826/ > > Roger > [1] JDK-8078582 <https://bugs.openjdk.java.net/browse/JDK-8078582> > java/lang/Runtime/exec/LotsOfOutput.java fails intermittently with Process > consumes memory > > On 4/28/2015 3:56 AM, Chris Hegarty wrote: >> On 27 Apr 2015, at 21:54, Roger Riggs <roger.ri...@oracle.com> wrote: >> >>> Please review adding diagnostic output to identify an intermittent failure. >> I agree with the adding additional diagnostic output. Maybe the bug >> description should be updated to indicate that? >> >>> Webrev: >>> http://cr.openjdk.java.net/~rriggs/webrev-lots-8078582/ >> I typically do not add the bug number to the @bug tag for non-product >> changes. I think this is right, since the test is not testing the product >> for that bug. >> >> -Chris. >> >>> Issue: >>> https://bugs.openjdk.java.net/browse/JDK-8078582 >>> >>> Thanks, Roger >>> >
