On 15/05/2015 16:13, Miroslav Kos wrote:
Hi everybody,
this is review request for: 8072839: JAX-B Plugability Layer: using
java.util.ServiceLoader
The JAX-B API changed a little bit - proprietary ServiceLoader-like
code has been replaced by java.util.ServiceLoader. This change is
required by Jigsaw, old configuration way still supported.
JBS:https://bugs.openjdk.java.net/browse/JDK-8072839
webrev: http://cr.openjdk.java.net/~mkos/8072839/jaxws.02/index.html
I skimmed through this and it mostly looks okay. Some really long (200+)
lines but that seems to be normal in this area. At some point it would
be good to do a wider pass over this code and replace the old style tags
(<tt> etc.) with newer forms.
In JAXBContext it looks likes a typo "loading facilities" when I assume
it should be "loading facility".
Are there any new tests for this? Existing tests will exercise some of
this but I don't see any tests that will exercise JAXBContextFactory.
-Alan.
