I noticed you have added braces for single line if-statements elsewhere.
But here you have
src/share/classes/com/sun/java/util/jar/pack/Utils.java
+ if (tz != null) TimeZone.setDefault(tz);
Besides that we are good.
Thanks
Kumar
On 5/19/2015 11:13 AM, mikhail cherkasov wrote:
Hi there,
I reverted the last change, now test uses native unpacker as before.
But I fixed the test other way, now I warm up native unpacker to make
it initialized on native level before
the main part of test:
http://cr.openjdk.java.net/~mcherkas/8066985/webrev.11/test/tools/pack200/DefaultTimeZoneTest.java.html
Thanks,
Mikhail.
On 3/31/2015 10:08 PM, mikhail cherkasov wrote:
And one more change in test.
Native packer/unpacker can throw exception during execution, but this
issue is out of scope of this fix,
so I just disable it for test:
http://cr.openjdk.java.net/~mcherkas/8066985/webrev.09/test/tools/pack200/DefaultTimeZoneTest.java.html
On 3/30/2015 1:27 PM, mikhail cherkasov wrote:
On 3/27/2015 6:59 PM, Kumar Srinivasan wrote:
yes that will work!, also why aren't all these final ?
fixed: http://cr.openjdk.java.net/~mcherkas/8066985/webrev.08/
