On 23/06/15 13:13, Paul Sandoz wrote:
On Jun 23, 2015, at 10:53 AM, Seán Coffey <[email protected]> wrote:
Hi Paul,
Best to get a peer review on this before pushing to jdk8u-dev.
Ok, including core-libs.
The backport changes look good. Keeping the code in sync with 9 makes sense.
-Chris.
The JPRT job passed. I additionally ran the 8b JCK tests, which all passed.
Paul.
Approved. If you get this into jdk8u-dev before Friday it should make the
pre-RDP2 integration slot. After this week, an 8u60-dev stabilization forest
will be created for ramp down purposes.
Regards,
Sean.
On 23/06/2015 09:32, Paul Sandoz wrote:
Hi,
I would like to backport:
https://bugs.openjdk.java.net/browse/JDK-8129120
9 changeset
http://hg.openjdk.java.net/jdk9/dev/jdk/rev/d9eadfd5659d
Review:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-June/034203.html
The 9 changeset does not apply cleanly to the following source:
src/share/classes/java/util/stream/AbstractPipeline.java
test/java/util/stream/test/org/openjdk/tests/java/util/stream/DistinctOpTest.java
The 8u patch is here:
http://cr.openjdk.java.net/~psandoz/jdk8u/JDK-8129120-flag-back-propagation/webrev/
For 8u AbstractPipeline.java the update was simply to remove the method
parallelPrepare and replace the 8u method
sourceSpliterator with the equivalent 9 method.
For 8u DistinctOpTest.java the expansion of the imports and reformatting result
in failure to apply all the patch cleanly.
All stream tests pass locally.
A JPRT job is underway.
I would like to wait a day or two to let the 9 changeset get tested by the
infrastructure (i don't anticipate any issues). But wanted to ask for approval
now assuming there are no issues with 9 and the JPRT job pass.
Paul.
