Your change [1] looks fine to me Steve.
-Chris.
[1] diff --git
a/src/java.prefs/macosx/classes/java/util/prefs/MacOSXPreferences.java
b/src/java.prefs/macosx/classes/java/util/prefs/MacOSXPreferences.java
--- a/src/java.prefs/macosx/classes/java/util/prefs/MacOSXPreferences.java
+++ b/src/java.prefs/macosx/classes/java/util/prefs/MacOSXPreferences.java
@@ -37,9 +37,6 @@
// true if this node is a child of userRoot or is userRoot
private final boolean isUser;
- // true if this node is userRoot or systemRoot
- private final boolean isRoot;
-
// CF's storage location for this node and its keys
private final MacOSXPreferencesFile file;
@@ -94,7 +91,6 @@
boolean isNew, boolean isRoot, boolean isUser)
{
super(parent, name);
- this.isRoot = isRoot;
if (isRoot)
this.isUser = isUser;
else
@@ -115,7 +111,6 @@
// /one/two/three/four/five/
// The fourth slash is the end of the first three components.
// If there is no fourth slash, the name has fewer than 3 components
- int componentCount = 0;
int pos = -1;
for (int i = 0; i < 4; i++) {
pos = name.indexOf('/', pos+1);
-Chris.
On 22 Jul 2015, at 23:08, Steve Drach <steve.dr...@oracle.com> wrote:
> Hello,
>
> Please review the fix for JDK-8066013, removing two unused variables from
> MacOSXPreferences.java.
>
> https://bugs.openjdk.java.net/browse/JDK-8066013
> <https://bugs.openjdk.java.net/browse/JDK-8066013>
> http://slc01hfj.us.oracle.com/webrevs/JDK-8066013/webrev/index.html
> <http://slc01hfj.us.oracle.com/webrevs/JDK-8066013/webrev/index.html>
>
> An internal review has been completed.
>
> Thanks,
> Steve
