Hi Frank,

That looks fine. However, instead of appending an additional directory "utests", you could make the paths shorter by removing "javax/xml" and "org/w3c" or "org/xml". The short names are good enough to represent the API names, test/javax/xml/jaxp/unittest/parsers for example, is easily recognizable as a package that holds the tests for javax/xml/parsers. JAXP tests currently in the jdk test repositories are named using this approach.

Thanks,
Joe

On 8/3/2015 11:51 PM, Frank Yuan wrote:

Hi, Joe and all

Would you like to have a review for bug https://bugs.openjdk.java.net/browse/JDK-8132660?

This is already on our plan for a while, but I have to finish it now because these unit tests failed with latest Jigsaw build. However I made the changes based on 9-dev repo, I tested them with both Jigsaw build and 9-dev build. The JPRT successful mail is enclosed in the bug.

The webrev is at: http://cr.openjdk.java.net/~fyuan/8132660/webrev.00/ <http://cr.openjdk.java.net/%7Efyuan/8132660/webrev.00/>. It seems to be a big change but actually there are only some directories changed.

Thanks,

Frank


Reply via email to