Hi Alexander,
On 04/08/15 19:34, Alexander Stepanov wrote:
Hello Daniel,
The review was re-uploaded as specdiff indeed discovered a couple of
unwanted changes (in 'InitialContext' and 'ReferralException'), so your
and Pavel's recommendations were very useful, thanks.
webrev (please update the web-page):
http://cr.openjdk.java.net/~avstepan/8132877/webrev.01/index.html
sdiff out (0 changes at the moment):
http://cr.openjdk.java.net/~avstepan/8132877/specdiff.01/overview-summary.html
Looks good for me then.
best regards,
-- daniel
Regards,
Alexander
On 8/4/2015 11:56 AM, Daniel Fuchs wrote:
Hi Alexander,
I had a look at
http://cr.openjdk.java.net/~avstepan/8132877/webrev.01/jdk.patch, and
there's nothing that caught my eye.
However - it would be good if you could generate a specdiff so that
we could verify that no mistake has crept in.
best regards,
-- daniel
On 03/08/15 17:39, Alexander Stepanov wrote:
just in case, the updated webrev:
http://cr.openjdk.java.net/~avstepan/8132877/webrev.01/index.html
On 8/3/2015 4:01 PM, Alexander Stepanov wrote:
P.S. I have also to replace <code>{@link ...}</code> with just {@link
...} in a couple of places here (as in the previous RFR 8132468...)
Regards,
Alexander
On 8/3/2015 3:57 PM, Alexander Stepanov wrote:
Thanks!
On 8/3/2015 3:53 PM, Lance Andersen wrote:
I think this looks ok also.
I agree with Daniel that we have additional clean-up opportunities
throughout we can do to the javadocs, but keeping each change set
more narrow helps reduce the chance of introducing additional
errors
Best
Lance
On Aug 3, 2015, at 5:43 AM, Alexander Stepanov
<alexander.v.stepa...@oracle.com
<mailto:alexander.v.stepa...@oracle.com>> wrote:
http://cr.openjdk.java.net/~avstepan/8132877/webrev.00/
<http://cr.openjdk.java.net/%7Eavstepan/8132877/webrev.00/>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
