On Tue, Aug 11, 2015 at 6:38 AM, Roger Riggs <[email protected]> wrote: > Hi Volker, > > Looks fine. >
Thanks! > Is there any way to test this? > It seems like it needs a special file system state that would not be readily > available. > Yes, it's not easy to reproduce the problem. I've tried to create a file with the same attributes and access control lists like the offending PGP files but couldn't succeed to reproduce the problem with them. Even if I copy the offending file, the problem will not show on the copy any more. So there must be something special about these files but I couldn't find out what. > Thanks, Roger > > > > On 8/10/15 9:57 AM, Volker Simonis wrote: >> >> Hi, >> >> can somebody please review this trivial fix? >> >> Thanks, >> Volker >> >> >> On Thu, Aug 6, 2015 at 5:27 PM, Volker Simonis <[email protected]> >> wrote: >>> >>> Hi, >>> >>> can somebody please review the following small fix contributed by >>> [email protected]: >>> >>> http://cr.openjdk.java.net/~simonis/webrevs/2015/8133105/ >>> https://bugs.openjdk.java.net/browse/JDK-8133105 >>> >>> Getting file attributes on Windows via GetFileAttributesExW() can fail >>> for some special system files. There is already code in >>> getFinalAttributes() which handles some of these special cases by >>> using FindFirstFileW(). >>> >>> However there are still cases which are not covered until now. For >>> example on PGP WDE (Whole Disk Encryption) – encrypted machines the >>> test java/io/File/WinSpecialFiles still fails for PGP files like >>> C:\pgpwde01. This small change fixes the issue. >>> >>> Thank you and best regards, >>> Volker > >
