Hi,

+         * The output is discarded by writing to the operating specific
+         * <em>null</em> file.

Small Javadocs issue, it should be "... operating system specific ..."

Uwe

-----
Uwe Schindler
uschind...@apache.org 
ASF Member, Apache Lucene PMC / Committer
Bremen, Germany
http://lucene.apache.org/

> -----Original Message-----
> From: core-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net] On
> Behalf Of Roger Riggs
> Sent: Monday, September 21, 2015 7:48 PM
> To: Core-Libs-Dev
> Subject: Re: RFR: 8132541 : (process) ProcessBuilder support for redirection
> to discard output
> 
> Ping?
> 
> Can a Reviewer take a look and comment?
> 
> Webrev:
>     http://cr.openjdk.java.net/~rriggs/webrev-8132541-discard/
> 
> 
> Thanks, Roger
> 
> 
> On 09/11/2015 01:11 PM, Remi Forax wrote:
> > Great !,
> > minor comments,
> > nullFile should be NULL_FILE and @since 9 -> @since 1.9
> >
> > regards,
> > Rémi
> >
> > ----- Mail original -----
> >> De: "Roger Riggs" <roger.ri...@oracle.com>
> >> À: "Core-Libs-Dev" <core-libs-dev@openjdk.java.net>
> >> Envoyé: Vendredi 11 Septembre 2015 17:30:06
> >> Objet: RFR: 8132541 : (process) ProcessBuilder support for redirection to
>       discard output
> >>
> >> Please review a proposed [1] ProcessBuilder addition to define a
> >> Redirect that will discard output.
> >> The implementation is to redirect output to /dev/null or NUL on
> Windows.
> >>
> >> Please review and comment if there are any unexpected side effects.
> >>
> >> Webrev:
> >>     http://cr.openjdk.java.net/~rriggs/webrev-8132541-discard/
> >>
> >> Issue:
> >>     https://bugs.openjdk.java.net/browse/JDK-8132541
> >>
> >> Thanks, Roger
> >>
> >> [1]
> >> http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-July/034639
> >> .html
> >>

Reply via email to