On Sat, Sep 19, 2015 at 6:58 AM, Alexander Stepanov < alexander.v.stepa...@oracle.com> wrote:
> Hello, > > Could you please review the following fix > http://cr.openjdk.java.net/~avstepan/8133651/jdk.00/ > http://cr.openjdk.java.net/~avstepan/8133651/jaxws.00/index.html > for > https://bugs.openjdk.java.net/browse/JDK-8133651 > > Just another portion of deprecated <tt> (and <xmp>) tags replaced with > {@code }. Some misprints were also fixed. > I'm biased of course, but I like the approach I took with blessed-modifier-order: - make the change completely automated - leave "human editing" for a separate change - publish the code used to make the automated change (in my case, typically a perl one-liner) > > The following (expected) changes were detected by specdiff: > - removed needless dashes in java.util.Locale, > - removed needless curly brace in xml.bind.annotation.XmlElementRef > I would do a separate automated "removed needless dashes" changeset. > Please let me know if the following changes are desirable or not: > > http://cr.openjdk.java.net/~avstepan/8133651/jdk.00/src/jdk.jconsole/share/classes/sun/tools/jconsole/Formatter.java.udiff.html This is an actual change to the behavior of this code - the maintainers of jconsole need to approve it. It's probably correct, but I would have left it out of this change. If you remove it, then I approve this change.
