On 24 Sep 2015, at 15:37, Alan Bateman <alan.bate...@oracle.com> wrote:
> On 24/09/2015 15:16, Chris Hegarty wrote: >> In preparation for JEP 260 "Encapsulate Most Internal APIs” [1], >> SharedSecrets and friend interfaces should be moved out of >> 'sun.misc’ [2] and located in a truly private package. This is so that >> they are not part of the proposed to be exported ‘sun.misc' >> package. >> >> http://cr.openjdk.java.net/~chegar/8137056.00/ >> > This looks okay to me, just a minor nit in PresentationManager where you've > introduced a raw type. If we can drop the building of the interim CORBA then > this code could be cleaned up to not use core reflection. Ah ha, good catch. Fixed and webrev updated in-place. Offline, Paul queried whether the modules now using jdk.internal.misc still require access to sun.misc. They do, all but one java.sql. I updated the modules.xml to reflect this. Worth noting, is that this change includes a workaround for 8137017: Remove JDK internal API dependency from jrt-fs.jar [1], in jdk/internal/jimage/ImageNativeSubstrate.java -Chris. [1] https://bugs.openjdk.java.net/browse/JDK-8137017
