Thanks Mandy and Lance for the review! Changes pushed.
-Joe
On 9/25/2015 3:40 PM, Mandy Chung wrote:
On 09/25/2015 02:38 PM, huizhe wang wrote:
With this application/libraries used to put xml-apis-2.11.0.jar on
the endorsed/ext directory or classpath no longer needs to do that
because org.w3c.dom.ElementTraversal was not part of the DOM API
endorsed by JAXP in JDK 8.
I skimmed through the change that looks okay.
214 URI _uri = new URI(uri, true);
This change removed the catching of MalformedURLException that will
fall back to use parentBaseURI. i.e. now it won't fall back to use
parentBaseURI if line 214 throws MUE. Is that intentional?
Yes. It was a performance improvement, quote:
Reduce MalformedURIExceptions thrown while
resolving xml:base. The URI class previously only accepted
absolute URIs so at least one exception was always being
thrown for relative URIs.
Okay. Sounds good.
Mandy
