On 30/09/15 16:50, Georgiy Rakov wrote:
Hello Miroslav,
could you please see some more comments below:
1. I believe it's better to say that exactly "fully qualified name" of
the provider factory implementation class is assumed to be the value
of the property:
* {@code javax.xml.soap.SOAPFactory}). If such property exists then its
value is assumed to be/_*the provider*_/
*/_*factory class*_/. This phase of the look up enables per-JVM override
of the SAAJ implementation.
This has been done in the next step of lookup procedure and this looks
reasonable:
* {@code conf} directory of the Java installation. It contains
the/_*fully qualified *_/ */_*name*_/ ...
Will fix, thanks.
2. This is not related to ServiceLoader feature, but anyway -
SAAJMetaFactory.java:
30 * SAAJ API./_*All *_//_*of the {@code newInstance} methods defined on
factories*_/ in
31 * SAAJ 1.3 defer to instances of this class to do the actual object
creation.
Namely it says that /_*all*_/**the newInstance methods defined on
factories delegate factory creation to SAAJMetaFactory instances, but
this seems to be not exactly true because SOAPConnectionFactory is not
created by SAAJMetaFactory instance.
Yes, good catch. To fix it, it would be good to add a new abstract method
public abstract SOAPConnectionFactory newSOAPConnectionFactory()
throws SOAPException, UnsupportedOperationException
Would you agree, Deva, Chen? There is a problem with backwards
compatibility here ... More defensive would be to name the two factories
instead of saying "all"?
Thanks
Miran
Btw. I sent this RFR initially to wrong mailing lists, would you check
when answering that it's to Core-Libs-Dev
<core-libs-dev@openjdk.java.net> ?
Thank you,
Georgiy.
On 25.09.2015 16:34, Miroslav Kos wrote:
Ping ...
On 11/09/15 17:57, Miroslav Kos wrote:
Hi again,
would somebody find a time to review?
Thanks
Miran
On 20/08/15 16:17, Miroslav Kos wrote:
Hi everybody,
I am sending changes for review for
JDK-8131334: SAAJ Plugability Layer: using java.util.ServiceLoader
JBS: https://bugs.openjdk.java.net/browse/JDK-8131334
webrev: http://cr.openjdk.java.net/~mkos/8131334/jaxws.01/
It's about migrating to standard java.util.ServiceLoader. This part
of service discovery was implemented previously "own" way. There
are some changes in javadoc and implementation has been refactored
in order to use same code as in JAX-WS and JAX-B.
Testing - I run JAX-WS unit tests (JAX-WS standalone repo), JCK9 +
new tests specificaly developed for testing service discovery in SAAJ.
Thanks
Miran
