Hi Brian,
On 10/14/2015 1:34 PM, Brian Burkhalter wrote:
Hi Joe,
On Oct 12, 2015, at 8:53 AM, joe darcy <[email protected]
<mailto:[email protected]>> wrote:
Please review the next step of porting fdlibm to Java, the cbrt method:
JDK-8136799 Port fdlibm cbrt to Java
http://cr.openjdk.java.net/~darcy/8136799.3/
<http://cr.openjdk.java.net/%7Edarcy/8136799.3/>
FdLibm.java:
* I assume that the diffs other than those of the Cbrt class itself
are artifacts of webrev creation and no other (significant) changes
are present elsewhere in the patch.
* Based on code inspection, the cbrt port itself appears to be accurate.
CubeRootTests.java:
* line 487: “hypot” -> “cbrt”
* line 504: probably need to insert a blank line after this line and
possibly remove the blank line at 507.
Corrected and pushed; thanks,
-Joe
