> On 3 Nov 2015, at 17:21, Roger Riggs <roger.ri...@oracle.com> wrote:
> 
> Hi Paul,
> 
> Thanks for the review.
> 
> The webrev is updated in place:
> http://cr.openjdk.java.net/~rriggs/webrev-process-clarify-8138566/
> 
> 
> I added an @apiNote to both onExit methods:
> 
>     * The process may be observed to have terminated with {@link #isAlive}
>     * before the ComputableFuture is completed and dependent actions are 
> invoked.
> 
> It is not strong enough for happens-before due to multi-threading possibly 
> under conditions
> where a thread might experience arbitrary delays in the implementation of 
> isAlive.
> 
> A minior update in ProcessUtil: the getAllChildren is renamed to 
> getDescendants.
> 

+1

Paul.

Reply via email to