Hi Joe,
Is there a reason to upgrade them if the tests don't actually require
b12? BTW, there are more than just those two repos. The following all
have TEST.ROOT:
bash-4.1$ find . -name TEST.ROOT
./hotspot/agent/test/jdi/TEST.ROOT
./hotspot/test/TEST.ROOT
./deploy/test/TEST.ROOT
./nashorn/test/TEST.ROOT
./jaxp/test/TEST.ROOT
./jdk/test/TEST.ROOT
./langtools/make/test/TEST.ROOT
./langtools/test/TEST.ROOT
But not all of the above specify requiredVersion
bash-4.1$ grep requiredVersion `find . -name TEST.ROOT`
./hotspot/test/TEST.ROOT:requiredVersion=4.1 b12
./deploy/test/TEST.ROOT:requiredVersion=4.1 b11
./nashorn/test/TEST.ROOT:requiredVersion=4.1 b11
./jaxp/test/TEST.ROOT:requiredVersion=4.1 b11
./jdk/test/TEST.ROOT:requiredVersion=4.1 b12
./langtools/test/TEST.ROOT:requiredVersion=4.1 b11
(Note the ones with b12 are the ones I've already modified for this commit)
thanks,
Chris
On 11/5/15 9:17 AM, joe darcy wrote:
Hi Chris,
The langtools and jaxp repos also have TEST.ROOT files with a
requiredVersion clause. I'd prefer if the files in those repos were
updated at the same to b12.
Thanks,
-Joe
On 11/4/2015 6:25 PM, Chris Plummer wrote:
Please review the following changes:
http://cr.openjdk.java.net/~cjplummer/8141489/
https://bugs.openjdk.java.net/browse/JDK-8141489
The changes I did for 8140189 require that version 4.1 b12 of jtreg
be used, so TEST.ROOT has been updated to reflect this.
Testing with JPRT right now. I also ran with b11 and confirmed that
the following errors are produced for hotspot and jdk tests:
Error: The testsuite at /local/ws/jdk9/hs-rt.8141489/jdk/test
requires jtreg version 4.1 b12 or higher and this is jtreg version
4.1 b11.
Error: The testsuite at /local/ws/jdk9/hs-rt.8141489/hotspot/test
requires jtreg version 4.1 b12 or higher and this is jtreg version
4.1 b11.
thanks,
Chris
