Hi Joe, Thank you and Ulf for catching the error message typo as we changed the name of the method. I will fix that before I push
Best Lance On Nov 23, 2015, at 7:09 PM, huizhe wang <huizhe.w...@oracle.com> wrote: > Hi Lance, > > Looks good, except as Ulf pointed out already, in both in Connection.java and > XAConnection.java, SQLFeatureNotSupportedException should have been thrown > with a message "setShardingKeyIfValid not implemented" rather than "isValid > not implemented" (4 occurrences in total). > > Best, > Joe > > On 11/23/2015 3:01 PM, Lance Andersen wrote: >> Hi all, >> >> Need a reviewer for 8085984, which adds support for Sharding. The CCC has >> been approved. The webrev can be found at >> http://cr.openjdk.java.net/~lancea/8085984/webrev.00/ >> >> Best, >> Lance >> >> >> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 >> Oracle Java Engineering >> 1 Network Drive >> Burlington, MA 01803 >> lance.ander...@oracle.com >> >> >> > Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
