Hi Lance,
Statement.java:
- "contains a {@code null} character or double quote, and is not a
simple SQL identifier."
The "," is not needed and changes the semantics if it is present.
+1518:
- "The string is between 1 and 128 characters in length"
You might want to add the word inclusive, otherwise I interpret the
length to be value >=2 and <= 127.
The rest is fine.
Roger
On 11/24/2015 2:48 PM, Lance Andersen wrote:
Hi,
Please provide a review for
http://cr.openjdk.java.net/~lancea/8143165/webrev.00/. This adds
Statement.isSimpleIdentifier, adds a throws SQLException to
Statement.enquoteLiteral and includes a few additional tests
Best
Lance
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
