FWIW.  The entire webrev with this patch:
   http://cr.openjdk.java.net/~mchung/jdk9/jep259/webrev.05/

Mandy

> On Nov 24, 2015, at 12:54 PM, Mandy Chung <mandy.ch...@oracle.com> wrote:
> 
> The failed tests now passed with fast debug and product build (manually 
> verified on solaris x64 and sparcv9 machines).  JPRT job to run all core 
> tests with fast debug and product build is in progress.
> 
> Mandy
> 
>> On Nov 24, 2015, at 12:52 PM, Mandy Chung <mandy.ch...@oracle.com> wrote:
>> 
>> The value of anchor is an address and it’s an unsigned value.  The check 
>> should be fixed to handle unsigned value.  
>> 
>> diff --git a/src/java.base/share/classes/java/lang/StackStreamFactory.java 
>> b/src/java.base/share/classes/java/lang/StackStreamFactory.java
>> --- a/src/java.base/share/classes/java/lang/StackStreamFactory.java
>> +++ b/src/java.base/share/classes/java/lang/StackStreamFactory.java
>> @@ -230,8 +230,8 @@
>>                    }
>>                    break;
>>                case OPEN:
>> -                    if (this.anchor <= 0) {
>> -                        throw new IllegalStateException("This stack stream 
>> is not valid for walking");
>> +                    if (this.anchor == 0 || this.anchor == -1L) {
>> +                        throw new IllegalStateException("This stack stream 
>> is not valid for walking: " + anchor);
>>                    }
>>                    break;
>>                case CLOSED:
>> 
>> Thanks
>> Mandy
> 

Reply via email to