Hi, Alan.
Thanks for looking.
> Is jdk.OracleVersion really intended to be pushed to OpenJDK?
That class should be available to users of the Oracle JDK. It is
not applicable to OpenJDK.
> Should it be final?
Yes.
> There are few imports at the top that don't appear to be used.
Oops. Thought I cleaned those up.
Here's the diff for both of these changes to OracleVersion:
28,33d27
< import java.util.regex.Matcher;
< import java.util.regex.Pattern;
< import java.util.ArrayList;
< import java.util.List;
< import java.util.Optional;
<
86c80
< public class OracleVersion extends Version
---
> public final class OracleVersion extends Version
> jdk.Version looks good. Has there been any thought/suggestions yet on
> which module this API will move too?
No. My best guess is jdk.dev for Version but I'm willing to take
suggestions. I'd prefer to keep Version and OracleVersion in the same
module, but if they need to be split, I'll need to change the access
modifier for the Version constructor.
> I suspect the docs build will need to be looked at.
Definitely. I was surprised (but pleased) that javadoc ran on the new
files, but the actual bundle surprised me. It is not correct for either
jdk.Exported or these classes. I was unable to find a more suitable
existing javadoc bundle. Is there one?
Regards,
iris
-----Original Message-----
From: Alan Bateman
Sent: Wednesday, November 25, 2015 4:02 AM
To: Iris Clark; core-libs-dev@openjdk.java.net
Cc: verona-...@openjdk.java.net
Subject: Re: RFR: 8072379: Implement jdk.Version and jdk.OracleVersion
On 25/11/2015 01:54, Iris Clark wrote:
> Hi.
>
> Please review the new classes jdk.Version and jdk.OracleVersion.
> These are simple Java APIs to parse, validate, and compare version numbers.
Is jdk.OracleVersion really intended to be pushed to OpenJDK? Should it be
final? There are few imports at the top that don't appear to be used.
jdk.Version looks good. Has there been any thought/suggestions yet on which
module this API will move too?
I suspect the docs build will need to be looked at. The javadoc for
jdk.Exported is currently generated in the javac tree javadoc for some reason
(maybe because that annotation started out in the langtools repo).
-Alan
