Hi Joe, On Nov 29, 2015, at 10:01 AM, joe darcy <joe.da...@oracle.com> wrote:
> The "if (...) " logic that is repeated a few times in this method could be > pulled out into its own method, possibly one structured a bit differently to > return the number of errors. > > I think it would be acceptable to push the tests in their current state, but > I would prefer to see a little more refactoring. > > I would have expected some tests to directly work off of the definition of > integer square root, namely that k^2 is less or or equal to the argument but > (k+1)^2 is larger. I have updated the patch per your comments above. The new version is here: http://cr.openjdk.java.net/~bpb/8032027/webrev.03/ Thanks, Brian
