Hi Paul,
Just a nit more:
120 int valuesPerWidth = LOG2_ARRAY_LONG_INDEX_SCALE -
log2ArrayIndexScale;
Would it be more correct to call that variable log2ValuesPerWidth?
Regards, Peter
On 11/30/2015 04:21 PM, Paul Sandoz wrote:
On 25 Nov 2015, at 10:53, Paul Sandoz <paul.san...@oracle.com> wrote:
Hi,
And this is the review for the Java part:
http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8136924-arrays-mismatch-vectorized-unsafe/webrev/
Which will be updated to add @HotSpotIntrinsicCandidate when JDK-8143355 is
pushed. [1]
The plan is all reviewed changes will be pushed to hs-comp and then we follow
up:
1) adding the intrinsic to other platforms
2) improving C1 (perhaps even the interpreter?) since the intrinsic is a stub
which IIUC makes it easier to plug in.
3) take a swing at consolidating other equal/compare intrinsics, such as
those for char[]/String-based equal/compare
4) adding methods to String such as mismatch method.
I can help by pushing all reviewed patches. I will kick off a JPRT run with all
patches applied.
JPRT runs for both core and hotspot tests report no issues.
Paul.
I did evaluate/test the HotSpot patch (stared at the patch and generated code for
UseAVX < 2, and measured) and reviewed with my limited knowledge of HotSpot.
Paul.
