> On Nov 26, 2015, at 8:22 AM, Paul Sandoz <paul.san...@oracle.com> wrote: > > Hi, > > I have updated the patches: > > > http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8133348-reachability-fence-jdk/webrev/ > > http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8133348-reachability-fence-hotspot/webrev/ > > There is now more documentation on Reference (copied and suitable rearranged > from 166 Fences.java). The method name remains the same. >
I think the addition to the Reference class specification should belong to the reachabilityFence method specification. Any reason why not? I suggest to change this (occurs in the class spec and the method spec): <em>strongly reachable</em> (as defined in the {@link java.lang.ref} package documentation), to <a href=“package-summary.html#reachability”><em>strongly reachable</em></a> Should the reachabilityFence method throw NPE if ref is null? Mandy