Hi,
Please review the updated webrevs
http://cr.openjdk.java.net/~sundar/8143404/jdk/webrev.01/
http://cr.openjdk.java.net/~sundar/8143404/top/webrev.01/
http://cr.openjdk.java.net/~sundar/8143404/langtools/webrev.00/
Thanks,
-Sundar
On 12/4/2015 12:12 PM, Mandy Chung wrote:
Right. Run this on your repo after removing applescript
$ jdeps $BUILD_OUTPUTDIR/jdk/modules/jdk.deploy.os
You will see the dependency. It’s okay to remain the qualified exports. But
you should remove the dependency on java.desktop and java.scripting.
jdk/make/lib/Lib-jdk.deploy.osx.gmk
I assume libapplescriptengine should be removed too. So this makefile needs
update too.
Mandy
On Dec 3, 2015, at 8:35 PM, Sundararajan Athijegannathan
<sundararajan.athijegannat...@oracle.com> wrote:
I'm only removing applescript code. Not all of jdk.deploy.osx code (collection
etc). Not sure if jdk.deploy.osx dependencies can be completely removed (yet).
Removal of the other stuff has to be another bug. I'll update for other stuff
you mentioned.
-Sundar
On 12/4/2015 9:01 AM, Mandy Chung wrote:
On Dec 3, 2015, at 5:41 PM, Sundararajan Athijegannathan
<sundararajan.athijegannat...@oracle.com> wrote:
Hi,
Thanks. Updated:
http://cr.openjdk.java.net/~sundar/8143404/jdk/webrev.00/
http://cr.openjdk.java.net/~sundar/8143404/top/webrev.00/
http://cr.openjdk.java.net/~sundar/8143404/langtools/webrev.00/
jdk/src/jdk.deploy.osx/macosx/native/libapplescriptengine
- jdk webrev didn’t show they are removed.
jdk/make/lib/Lib-jdk.deploy.osx.gmk
unshuffle_list.txt
1296 jdk/src/jdk.deploy.osx/macosx/classes/apple/security :
jdk/src/macosx/classes/apple/security
since you are on this file, do you mind taking out this line as well (which was
a leftover from the changeset when moving out the apple security provider to
java.abs).
modules.xml
I believe this should be updated as well and jdk.deploy.osx dependency on
java.desktop and java.scripting can be removed.
I notice that there are qualified exports from sun.misc to jdk.deploy.osx that
looks like they are not needed. Run jdeps on
$BUILD_OUTPUTDIR/jdk/modules/jdk.deploy.osx from your build will show the new
dependency. It’d be good to clean this up but this is not related to this
change. It’s okay with me either way.
Mandy
