Hi Joel,
Sorry for the delay in reviewing.
For the specification, it should seem reasonable to me to have the
default implementation of AnnotatedType.getAnnotatedOwnerType() to
return null rather than throwing an UnsupportedOperationException.
Following experience with similar structures in the javax.lang.model
APIs, e.g.
JDK-7015530: Reiterate API specializations in
javax.lang.model.element subinterfaces
http://cr.openjdk.java.net/~darcy/7015530.1/
I think it is clearer to readers of the specification if description of
behavior like
// Supertype
/**
* In these subtypes, do this. In these other subtypes, do that.
*/
void foo();
is additionally copied down and specialized into the subtypes, even if
trivial overriden methods are defined whose only purpose is to serve as
a hook to hang the javadoc.
What do you think?
Thanks,
-Joe
On 12/7/2015 12:43 PM, Joel Borggrén-Franck wrote:
Hi Paul,
See inline,
On Mon, 7 Dec 2015 at 21:39 Paul Benedict <[email protected]> wrote:
Joel, some comments on AnnotatedType#getAnnotatedOwnerType():
* Is it convention to use <p> tags to describe the complexity of the
return value vs. just explaining it all in the @return tag?
It is for the Core Reflection javadocs. Compare with
j.l.Class.get(Declared)Thing.
* What is the convention for @see nowadays? Is it 1.9 or 9?
Good question. Anyone? I'll grep for 1.9 if it is still there in lots of
places I would expect "someone else" to do a big cleanup job.
cheers
/Joel
