Thanks! Looks good. For bonus points, one could check all the jdk test sources for non-ASCII characters. They should probably only ever be used in javac tests that are actually testing source file encoding.
On Thu, Dec 10, 2015 at 5:28 AM, Sergei Kovalev <sergei.kova...@oracle.com> wrote: > Hi, > > Could you please review the following patch? > > Bug ID: https://bugs.openjdk.java.net/browse/JDK-8078423 > Webrev: http://cr.openjdk.java.net/~skovalev/8078423/webrev.01/ > Summary: Compilation of the test fails if system locale is not UTF-8. > Description: Replace UTF-8 characters by Unicode escapes for non-ASCII > characters > > Testing done: tested manually on problematic host. The test fails with > LC_NAME="POSIX" without the fix, modified test passes. > > > -- With best regards, > Sergei > >
