Hm, not really a ringing endorsement.
On a second look, are the new test groups sufficiently close to the ones the JSR
166 maintainers would want to run? For example, your little 'find' script
(cd ~/ws/jdk9/jdk/test && find java/util -type d \( \( -name
concurrent -prune \) -o -name '*Set*' -o -name '*Map*' -o -name
'*List*' -o -name '*Queue*' -o -name '*Deque*' -o -name '*Collection*'
-o -name '*Vector*' -o -name '*Hashtable*' -o -name '*Array*' \) )
produces a list of tests that's quite close to the union of the jdk_collections
and jdk_concurrent groups. The only difference is that the test groups include
four additional tests:
+java/util/Comparator/BasicTest.java
+java/util/Comparator/TypeTest.java
+java/util/Iterator/IteratorDefaults.java
+java/util/Iterator/PrimitiveIteratorDefaults.java
I did this by comparing the results of "jtreg -listtests":
1. jtreg -listtests $(find ...)
2. jtreg -listtests :jdk_collections :jdk_concurrent
s'marks
On 12/11/15 11:34 AM, Martin Buchholz wrote:
This is "fine", but jsr166 maintainers won't use it - we maintain our
own list of tests to run. There's enough collection/concurrency
overlap and too much testing ad-hoc-ery in existing jtreg tests. Eg.
MOAT should be run for changes to any collection. If this is a test
set you personally like, sure go ahead and commit.
On Thu, Dec 10, 2015 at 2:39 PM, Stuart Marks <stuart.ma...@oracle.com> wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8145139
I've appended a patch below; please review.
Thanks,
s'marks
# HG changeset patch
# User smarks
# Date 1449787050 28800
# Thu Dec 10 14:37:30 2015 -0800
# Node ID 5b630d0c118b115439672b29aff0d195132d4f96
# Parent 7f644a5d554a67457f3dd535c4435643d3f65569
8145139: clean up jdk_collections and jdk_concurrent test groups
Reviewed-by: XXX
diff -r 7f644a5d554a -r 5b630d0c118b test/TEST.groups
--- a/test/TEST.groups Wed Dec 09 15:27:21 2015 -0500
+++ b/test/TEST.groups Thu Dec 10 14:37:30 2015 -0800
@@ -95,13 +95,10 @@
-:jdk_concurrent \
-:jdk_stream
-# java.util.concurrent (JSR-166)
+# java.util.concurrent
# Maintained by JSR-166 EG (Doug Lea et al)
-# Deque and PriorityQueue are also generally maintained by JSR-166
jdk_concurrent = \
- java/util/concurrent \
- java/util/Deque \
- java/util/PriorityQueue
+ java/util/concurrent
# Java Collections Framework
jdk_collections = \
@@ -114,19 +111,22 @@
java/util/BitSet \
java/util/Collection \
java/util/Collections \
+ java/util/Comparator \
+ java/util/Deque \
java/util/EnumMap \
java/util/EnumSet \
- java/util/Comparator \
- java/util/Iterator \
java/util/HashMap \
+ java/util/HashSet \
java/util/Hashtable \
java/util/IdentityHashMap \
- java/util/List \
+ java/util/Iterator \
java/util/LinkedHashMap \
java/util/LinkedHashSet \
java/util/LinkedList \
+ java/util/List \
java/util/Map \
java/util/NavigableMap \
+ java/util/PriorityQueue \
java/util/TimSort \
java/util/TreeMap \
java/util/Vector \
