Incorporated the changes suggested. Updated webrev is @
http://cr.openjdk.java.net/~sundar/8068938/webrev.01/
Thanks,
-Sundar
On 1/11/2016 2:26 PM, Alan Bateman wrote:
On 11/01/2016 05:03, Sundararajan Athijegannathan wrote:
Please review http://cr.openjdk.java.net/~sundar/8068938/webrev.00/
for https://bugs.openjdk.java.net/browse/JDK-8068938
This is a doc-only change to mention that ScriptEngineFactory
instances are loaded using java.util.ServiceLoader API and avoid
wording on META-INF/services [ which is just one impl. mechanism used
by ServiceLoader ]. This will allow the ScriptEngineFactory
implementations to be deployed as modules without the service
configuration file.
The original wording has "current ClassLoader" which isn't very clear,
does it mean the caller's class loader or the TCCL? The updated
wording removes this but leaves it ambiguous as to how
ScriptEngineFactory providers are located. Can it reference someone
where in the javax.script javadoc where this is more clearly specified?
<code>ScriptEngineFactories</code>, might be better as {@code
ScriptEngineFactory} instances.
I would be good to keep the line length somewhat consistent with the
rest of the class description. Having have one >100 char line will
also be annoying for future side-by-side diffs.
I assume this can go into jdk9/dev, no need for it to go into
jigsaw/jake.
-Alan.
