Hi Shilpi, Can you also double check Lookup.unreflectSpecial, it’s documentation might require updating too.
Separating the “or” statements with a comma would help readability in the JavaDoc (same applies to the the patch for findVirtual). Paul. > On 22 Jan 2016, at 10:22, shilpi rastogi <[email protected]> wrote: > > > Gentle Reminder! > > -------- Original Message -------- > Subject: [9u-dev] 8138578:MethodHandles.Lookup.findSpecial() Javadoc > fails to consider static methods > Date: Wed, 20 Jan 2016 18:12:30 +0530 > From: shilpi rastogi <[email protected]> > Organization: Oracle Corporation > To: [email protected] > > > > Hi All, > > Please review my fix related to java doc. > > MethodHandles.Lookup.findSpecial() Javadoc fails to consider static methods- > > MethodHandles.Lookup.findSpecial() throws IllegalAccessException if the > target method is static. > > Bug link- https://bugs.openjdk.java.net/browse/JDK-8138578 > <https://bugs.openjdk.java.net/browse/JDK-8138578> > Webrev link- http://cr.openjdk.java.net/~srastogi/8138578/webrev.00/ > <http://cr.openjdk.java.net/%7Esrastogi/8138578/webrev.00/> > > Thnaks, > Shilpi > >
