Hi Claes, thanks a lot, and I agree with the renaming.
Best, Michael > Am 02.03.2016 um 13:59 schrieb Claes Redestad <[email protected]>: > > Hi, > > this looks good to me. > > Maybe rename LoopTest to LoopCombinatorTest to add a bit of specificity? > > /Claes > > On 2016-03-02 13:46, Michael Haupt wrote: >> Dear all, >> >> please review this change. >> RFE: https://bugs.openjdk.java.net/browse/JDK-8150832 >> Webrev: http://cr.openjdk.java.net/~mhaupt/8150832/webrev.00 >> >> This is a refactoring; the monolithic test for JEP 274 was split into >> several tests along functionality covered. Also, data providers and other >> declarative annotations were introduced where it made sense. >> >> Thanks, >> >> Michael >> > -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
