comments inlinined ... ----- Mail original ----- > De: "Kumar Srinivasan" <kumar.x.sriniva...@oracle.com> > À: "core-libs-dev" <core-libs-dev@openjdk.java.net>, "Remi Forax" > <fo...@univ-mlv.fr> > Cc: "SUNDARARAJAN.ATHIJEGANNATHAN" <sundararajan.athijegannat...@oracle.com>, > "Michael Haupt" > <michael.ha...@oracle.com>, "Jaroslav Bachor?k" > <jaroslav.bacho...@oracle.com>, "Coleen Phillmore" > <coleen.phillim...@oracle.com>, "Stas Smirnov" > <stanislav.smir...@oracle.com>, "harsha wardhana b" > <harsha.wardhan...@oracle.com> > Envoyé: Mercredi 2 Mars 2016 16:41:01 > Objet: RFR: 8147755: ASM should create correct constant tag for invokestatic > on handle point to interface static > method > > Hello Remi, et. al.,
Hi Kumar, > > Webrev: > http://cr.openjdk.java.net/~ksrini/8147755/webrev.00/ > > Can you please approve this patch, it is taken out of ASM's svn repo. > change id 1795, which addresses the problem described in [1]. for anybody else, this revision roughtly correspond to ASM 5.1, which includes: - change non visible StringBuffer to StringBuilder - improve documentation of Printer API (and related classe) - provide a new Remapper API - add a way to create constant method handles on interface (invokestatic/invokespecial) which fix 8147755. > > Note 1: A couple of @Deprecated annotations and doc comments > have been disabled, because we have a catch-22 that an internal and closed > component depends on these APIs, and the replacement is not available until > we push this patch. A follow up bug [2] has been filed. for ASM, we use @Deprecated when a method is superseded by a new one, not to indicate that calling this method is hazardous, so i'm fine if you want to do the update in two steps. > > Note 2: jprt tested, all core-libs, langtools and nashorn regressions > pass. HotSpot team has verified that it address their issues. > > > Thank you > Kumar thumb up for me. Rémi > > [1] https://bugs.openjdk.java.net/browse/JDK-8147755 > [2] https://bugs.openjdk.java.net/browse/JDK-8151056 >
