After this patch, the version of ASM internally used by OpenJDK will accept V53 class files but not understand module-info.class specific file format, so that version of ASM will be able to read module-info.class, but will see it as a class with a bunch of custom attributes and will not be able to generate module-info.class.
so it's a kind of half broken version of ASM, my question is do you plan to read/write module-info with ASM (or as Jon said use Unicode 8 char sequence). regards, Rémi ----- Mail original ----- > De: "Alan Bateman" <alan.bate...@oracle.com> > À: fo...@univ-mlv.fr, "Sundararajan Athijegannathan" > <sundararajan.athijegannat...@oracle.com> > Cc: "Kumar Srinivasan" <kumar.x.sriniva...@oracle.com>, "Jonathan Gibbons" > <jonathan.gibb...@oracle.com>, > "core-libs-dev" <core-libs-dev@openjdk.java.net> > Envoyé: Mardi 15 Mars 2016 10:05:14 > Objet: Re: RFR: 8151858: update ASM 5.1 to accept V53.0 classfiles > > > On 15/03/2016 08:41, fo...@univ-mlv.fr wrote: > > +1 too, > > > > Upstream, we will wait to implement the module-info file format before > > bumping the supported major version. > > > > Do you need to support module-info file soon ? > > > We going to attempt to bring in the module system in jdk-9+111. The > jdk9/dev -> master integration for jdk-9+110 has already happened so > bumping the class version to 53.0 will go in after the module system. It > does mean the module-info.class will be at 52.0 for a short time but I > think we can live with that. > > -Alan >
