Hi Aleksej

I think the changeset is fine overall.

Once minor comment for 
http://cr.openjdk.java.net/~aefimov/8145039/9/test/javax/xml/bind/xjc/8145039/JaxbMarshallTest.java.html

Line 72: * 4. Marshall the new list instance to reproduce reported 
ClassCastException

You are validating that the Exception is not thrown so your probably want to 
adjust this comment before pushing

Best
Lance
On Mar 18, 2016, at 6:50 PM, Aleksej Efimov <aleksej.efi...@oracle.com> wrote:

> Hi,
> 
> Please, help to review the addition of new test for JDK-8145039 [1]:
> http://cr.openjdk.java.net/~aefimov/8145039/9
> The test requires full JDK hence it was added to 'needs_jdk' test group.
> 
> The source fix for this bug was already delivered to JDK9 as part of sync 
> with upstream JAXWS project [2]. The changes that fixed reported issue were 
> located in CTypeRef class and can be viewed at this location [3].
> It is also planned to do backport of CTypeRef source fix and JaxbMarshallTest 
> test to JDK8.
> 
> Test was executed without failures via JTREG and JPRT on all platforms.
> 
> With Best Regards,
> Aleksej
> 
> [1] https://bugs.openjdk.java.net/browse/JDK-8145039
> [2] https://bugs.openjdk.java.net/browse/JDK-8150174
> [3] http://hg.openjdk.java.net/jdk9/jdk9/jaxws/rev/ebff1bd3627a#l34.1



Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com



Reply via email to