> On Mar 23, 2016, at 4:54 AM, Alan Bateman <[email protected]> wrote: > > On 22/03/2016 18:41, Mandy Chung wrote: >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8151571/webrev.00/ >> >> This restores the change in NativeBuffer to use the common Cleaner created >> by the system. JDK-8149925 causes InnocuousThread be created early during >> startup before the system class loader is initialized. Since the common >> Cleaner is intended for system cleaning code to use, this patch now creates >> InnocuousThread with null TCCL and expects the system cleaning code to >> handle null TCCL only if it uses it. > This looks okay although the hasTCCL flag is a bit ugly. An alternative would > be for InnocuousThread to take the TCCL in the constructor and have it reject > all but null or the SCL.
I did consider taking ClassLoader parameter and I don’t like either option. I was tempted to convert the constructors to factory methods to avoid passing a ClassLoader or hasTCCL. Mandy
