Thanks Lance!

On 3/24/2016 1:02 PM, Lance Andersen wrote:
Looks OK Joe.

Joe and I talked offline about recognizing the test into the existing tests that he has


On Mar 24, 2016, at 12:30 PM, huizhe wang <huizhe.w...@oracle.com <mailto:huizhe.w...@oracle.com>> wrote:

Hi,

The issue was that the CatalogFeatures builder did not conduct any verification on inputs. The file path verification was done in the CatalogImpl before parsing started. This change added that to where the property was set in the builder, thus some refactoring (moving the verification methods to Util) was involved.

Please review:
JBS: https://bugs.openjdk.java.net/browse/JDK-8151154
Webrev: http://cr.openjdk.java.net/~joehw/jdk9/8151154/ <http://cr.openjdk.java.net/%7Ejoehw/jdk9/8151154/>

Thanks,
Joe

<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>




Reply via email to