Patch looks Ok to me. Rémi
----- Mail original ----- > De: "Claes Redestad" <claes.redes...@oracle.com> > À: "Remi Forax" <fo...@univ-mlv.fr> > Cc: "Peter Levart" <peter.lev...@gmail.com>, "Mandy Chung" > <mandy.ch...@oracle.com>, "jigsaw-dev" > <jigsaw-...@openjdk.java.net>, "core-libs-dev" > <core-libs-dev@openjdk.java.net> > Envoyé: Mercredi 30 Mars 2016 13:14:39 > Objet: Re: RFR: 8152641: Plugin to generate BMH$Species classes ahead-of-time > > Hi, > > On 2016-03-30 13:11, Remi Forax wrote: > > Hi Claes, > > Did you considere to use > > return c.asSubclass(BoundMethodHandle.class); > > instead of > > return (Class<? extends BoundMethodHandle>)c; > > to avoid the @SupressWarnings, like in generateConcreteBMHClass ? > > no, but it's a good cleanup. :-) > > Updated in-place: http://cr.openjdk.java.net/~redestad/8152641/webrev.03/ > > /Claes > >
