Hello Joe, and thanks!

The change is in the plugin and not the test, though, so might be as good as it gets (I've verified all jlink plugin tests work with this).

The surprising thing here to me is why these tests was running the plugin twice on the same (exploded) image since regurgitating an image didn't occur to me to be a valid/supported use-case.

/Claes

On 2016-04-01 22:32, joe darcy wrote:
Hello Claes,

I'll approve the test change in the interests of getting the tests back to green, but it does sound like some more investigation is warranted into what is going on. In other words, running down the root cause to make sure the same bad effect won't show up elsewhere.

Thanks,

-Joe

On 4/1/2016 1:25 PM, Claes Redestad wrote:
Hi,

seems my recent push for JDK-8152641 broke a jimage test or two.

While I think these test seem a bit odd, it's apparent that checking that we're not adding the same resource twice is enough to make the tests happy for now:

Webrev: http://cr.openjdk.java.net/~redestad/8153317/webrev.01/
Bug: https://bugs.openjdk.java.net/browse/JDK-8153317

Thanks!

/Claes


Reply via email to